Re: psql not responding to SIGINT upon db reconnection

Jelte Fennema <postgres@jeltef.nl>

From: Jelte Fennema-Nio <postgres@jeltef.nl>

To: Tom Lane <tgl@sss.pgh.pa.us>

Cc: Robert Haas <robertmhaas@gmail.com>, Tristan Partin <tristan@neon.tech>, Heikki Linnakangas <hlinnaka@iki.fi>, pgsql-hackers@postgresql.org, Shlok Kyal <shlok.kyal.oss@gmail.com>

Date: 2024-04-03T14:50:07Z

Lists: pgsql-hackers

Attachments

v12-0001-Fix-actually-reachable-pg_unreachable-call.patch (text/x-patch) patch v12-0001
v12-0002-Remove-PGRES_POLLING_ACTIVE-case.patch (text/x-patch) patch v12-0002

On Wed, 3 Apr 2024 at 16:31, Tom Lane <tgl@sss.pgh.pa.us> wrote:
> If we do the latter, we will almost certainly get pushback from
> distros who check for library ABI breaks.  I fear the comment
> suggesting that we could remove it someday is too optimistic.

Alright, changed patch 0002 to keep the variant. But remove it from
the recently added switch/case. And also updated the comment to remove
the "for awhile".

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

Fix old, misleading comment for PGRES_POLLING_ACTIVE.
- e57fe3824ee7 17.0 landed
Remove reachable call to pg_unreachable().
- 12b964d7815b 17.0 landed
Allow SIGINT to cancel psql database reconnections.
- cafe1056558f 17.0 landed
Expose PQsocketPoll via libpq
- f5e4dedfa81f 17.0 landed
Fix query cancellation handling in psql
- 5d43c3c54d77 13.0 cited