Re: CI: Add task that runs pgindent
Jelte Fennema-Nio <me@jeltef.nl>
From: Jelte Fennema-Nio <me@jeltef.nl>
To: Daniel Gustafsson <daniel@yesql.se>
Cc: Nazir Bilal Yavuz <byavuz81@gmail.com>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2025-10-21T14:31:00Z
Lists: pgsql-hackers
On Tue, 21 Oct 2025 at 15:27, Daniel Gustafsson <daniel@yesql.se> wrote: > > > On 21 Oct 2025, at 15:22, Nazir Bilal Yavuz <byavuz81@gmail.com> wrote: > > > Do you think that this task should format perl files as well? > > +1, if we do this we should run pgperltidy as well. I definitely agree that we should run that too. But currently the master branch isn't correctly formatted according to pgperltidy (at least with the pgperltidy on my machine I get a bunch of changes). So I guess koel doesn't complain about that yet, and I didn't want to conflate possible objectsions to that with objections to running pgindent in CI. Once this CI job is in I wanted to start that discussion for pgindent (and similarly a discussion on adding a python formatter/linter).