Re: CI: Add task that runs pgindent

Jelte Fennema-Nio <me@jeltef.nl>

From: Jelte Fennema-Nio <me@jeltef.nl>

To: Tom Lane <tgl@sss.pgh.pa.us>

Cc: Daniel Gustafsson <daniel@yesql.se>, Florents Tselai <florents.tselai@gmail.com>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>, Nazir Bilal Yavuz <byavuz81@gmail.com>

Date: 2025-10-22T08:41:49Z

Lists: pgsql-hackers

Attachments

v2-0001-CI-Add-task-that-runs-pgindent.patch (text/x-patch) patch v2-0001
v2-0002-Wrong-indent-to-test-job.patch (text/x-patch) patch v2-0002
image.png (image/png)

On Tue, 21 Oct 2025 at 16:49, Jelte Fennema-Nio <me@jeltef.nl> wrote:
> By having it be a separate job I can easily make the
> cfbot and commitfest app report it as "yellow" instead of "red" if
> this job fails.

I set "allow_failures: true" in the cirrus task, so that a formatting
failure won't show the whole build as failed. I updated the commitfest
app to now show it with an orange cross instead of a red one (see
attached png). I included a patch that breaks indentation so I can
easily test this new behaviour end-to-end.