Re: [EXTERNAL] Re: Support load balancing in libpq

Jelte Fennema-Nio <postgres@jeltef.nl>

From: Jelte Fennema <postgres@jeltef.nl>

To: Andrey Borodin <amborodin86@gmail.com>

Cc: Greg S <stark.cfm@gmail.com>, Jacob Champion <jchampion@timescale.com>, Maxim Orlov <orlovmg@gmail.com>, Jelte Fennema <Jelte.Fennema@microsoft.com>, Michael Banck <mbanck@gmx.net>, Aleksander Alekseev <aleksander@timescale.com>, "pgsql-hackers@postgresql.org" <pgsql-hackers@postgresql.org>, Andres Freund <andres@anarazel.de>

Date: 2023-03-03T14:37:55Z

Lists: pgsql-hackers

Attachments

v10-0003-Support-load-balancing-in-libpq.patch (application/octet-stream) patch v10-0003
v10-0002-Refactor-libpq-to-store-addrinfo-in-a-libpq-owne.patch (application/octet-stream) patch v10-0002
v10-0004-Remove-unnecessary-check-from-Fisher-Yates-imple.patch (application/octet-stream) patch v10-0004
v10-0001-libpq-Run-pgindent-after-a9e9a9f32b3.patch (application/octet-stream) patch v10-0001

> I want to note that the Fisher-Yates algorithm is implemented in a
> difficult to understand manner.
> +if (j < i) /* avoid fetching undefined data if j=i */
> This stuff does not make sense in case of shuffling arrays inplace. It
> is important only for making a new copy of an array and only in
> languages that cannot access uninitialized values. I'd suggest just
> removing this line (in both cases).

Done. Also added another patch to remove the same check from another
place in the codebase where it is unnecessary.

Commits

Fix pointer cast for seed calculation on 32-bit systems
- 2fe7a6df94e6 16.0 landed
Copy and store addrinfo in libpq-owned private memory
- 44d85ba5a336 16.0 landed
libpq: Use modern socket flags, if available.
- bfc9497ece01 16.0 cited