Horton

Re: [PATCH] Add pg_get_trigger_ddl() to retrieve the CREATE TRIGGER statement

Josef Šimánek <josef.simanek@gmail.com>

View thread
From: Josef Šimánek <josef.simanek@gmail.com>
To: Philip Alger <paalger0@gmail.com>
Cc: Josef Šimánek <retro@ballgag.cz>, jian he <jian.universality@gmail.com>, Jim Jones <jim.jones@uni-muenster.de>, Andrew Dunstan <andrew@dunslane.net>, Cary Huang <cary.huang@highgo.ca>, pgsql-hackers <pgsql-hackers@postgresql.org>
Date: 2025-11-03T01:30:55Z
Lists: pgsql-hackers 
po 3. 11. 2025 v 2:18 odesílatel Philip Alger <paalger0@gmail.com> napsal:
>
> Hi Josef,
>
>> Would it make sense to rename trigger related variables to "trig"
>> prefix instead of "trg" as is done in other functions in the same file
>> (for example in function pg_get_triggerdef)?
>
>
> Not sure it would be the same as triggerdef uses trig, while triggerdef_worker uses a mix of trig and tg in the same function. It would be another patch, I believe, to and correct a prefix, then you'd have to normalize all the other functions within the same file.

If you mind updating the current patch to not add a third version (or
spread the problem), I'm happy to provide a later separate patch to
unify terminology in that file for triggers.

> --
> Best,
> Phil Alger