Horton

Thread

Commits

  1. Remove bug from OPTIMIZER_DEBUG code for partition-wise join.

  1. Incorrect debug info printed in generate_partition_wise_join_paths

    Etsuro Fujita <fujita.etsuro@lab.ntt.co.jp> — 2017-12-08T09:52:38Z

    generate_partition_wise_join_paths prints debug info, if
OPTIMIZER_DEBUG, using debug_print_rel at the end of each iteration for
collecting non-dummy child-joins, but I noticed that we pass to that
function the parent's RelOptInfo, not such a child-join's RelOptInfo.  I
don't think it's intentional, so here is a patch for fixing that.

Best regards,
Etsuro Fujita

  2. Re: Incorrect debug info printed in generate_partition_wise_join_paths

    Ashutosh Bapat <ashutosh.bapat@enterprisedb.com> — 2017-12-11T08:24:26Z

    Yes, that's the correct fix. We should be printing debug information
about the child and not the parent. Sorry for that bug and thanks for
fixing it.

On Fri, Dec 8, 2017 at 3:22 PM, Etsuro Fujita
<fujita.etsuro@lab.ntt.co.jp> wrote:
> generate_partition_wise_join_paths prints debug info, if
> OPTIMIZER_DEBUG, using debug_print_rel at the end of each iteration for
> collecting non-dummy child-joins, but I noticed that we pass to that
> function the parent's RelOptInfo, not such a child-join's RelOptInfo.  I
> don't think it's intentional, so here is a patch for fixing that.
>
> Best regards,
> Etsuro Fujita



-- 
Best Wishes,
Ashutosh Bapat
EnterpriseDB Corporation
The Postgres Database Company

  3. Re: Incorrect debug info printed in generate_partition_wise_join_paths

    Etsuro Fujita <fujita.etsuro@lab.ntt.co.jp> — 2017-12-12T02:05:36Z

    (2017/12/11 17:24), Ashutosh Bapat wrote:
> Yes, that's the correct fix. We should be printing debug information
> about the child and not the parent.

Thanks for reviewing!

Best regards,
Etsuro Fujita

  4. Re: Incorrect debug info printed in generate_partition_wise_join_paths

    Robert Haas <robertmhaas@gmail.com> — 2017-12-12T15:56:32Z

    On Mon, Dec 11, 2017 at 9:05 PM, Etsuro Fujita
<fujita.etsuro@lab.ntt.co.jp> wrote:
> (2017/12/11 17:24), Ashutosh Bapat wrote:
>> Yes, that's the correct fix. We should be printing debug information
>> about the child and not the parent.
>
> Thanks for reviewing!

Committed.

-- 
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

  5. Re: Incorrect debug info printed in generate_partition_wise_join_paths

    Etsuro Fujita <fujita.etsuro@lab.ntt.co.jp> — 2017-12-13T02:41:45Z

    (2017/12/13 0:56), Robert Haas wrote:
> Committed.

Thanks!

Best regards,
Etsuro Fujita