Horton

Thread

Commits

  1. Minor code beautification in partition_bounds_equal.

  1. Use get_greatest_modulus() in partition_bounds_equal()

    Ashutosh Bapat <ashutosh.bapat@enterprisedb.com> — 2017-12-01T10:13:41Z

    Hi all,

partition_bounds_equal() accesses the last datum from the given
partition bounds directly to compare their greatest moduli. Rest of
the code uses get_greatest_modulus() to get the greatest modulus from
a partition bound. partition_bounds_equal() should also do the same
for the sake of consistency and to make sure the in future the code
remains sane if we change the way we store greatest modulus in
PartitionBoundInfoData in future.

-- 
Best Wishes,
Ashutosh Bapat
EnterpriseDB Corporation
The Postgres Database Company

  2. Re: Use get_greatest_modulus() in partition_bounds_equal()

    Robert Haas <robertmhaas@gmail.com> — 2017-12-01T18:55:48Z

    On Fri, Dec 1, 2017 at 5:13 AM, Ashutosh Bapat
<ashutosh.bapat@enterprisedb.com> wrote:
> partition_bounds_equal() accesses the last datum from the given
> partition bounds directly to compare their greatest moduli. Rest of
> the code uses get_greatest_modulus() to get the greatest modulus from
> a partition bound. partition_bounds_equal() should also do the same
> for the sake of consistency and to make sure the in future the code
> remains sane if we change the way we store greatest modulus in
> PartitionBoundInfoData in future.

Makes sense.  Committed.

-- 
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company