Re: TupleTableSlot abstraction

Ashutosh Bapat <ashutosh.bapat@enterprisedb.com>

From: Ashutosh Bapat <ashutosh.bapat@enterprisedb.com>

To: Andres Freund <andres@anarazel.de>

Cc: pgsql-hackers <pgsql-hackers@postgresql.org>, Robert Haas <robertmhaas@gmail.com>, Haribabu Kommi <kommi.haribabu@gmail.com>, Alvaro Herrera <alvherre@2ndquadrant.com>, Amit Kapila <amit.kapila16@gmail.com>

Date: 2018-08-09T11:42:08Z

Lists: pgsql-hackers

Attachments

pg_abstract_tts_patches_v6.tar.zip (application/zip)

On Wed, Aug 8, 2018 at 5:07 PM, Ashutosh Bapat
<ashutosh.bapat@enterprisedb.com> wrote:

Amit Khandekar offlist told me that the previous patch-set doesn't
apply cleanly on the latest head.

PFA patches rebased on 31380bc7c204e7cfa9c9e1c62947909e2b38577c

>>>>>
>>>>> 3. compile with LLVM and fix any compilation and regression errors.
>>>>
>>>> When I compiled server with just 0003 applied with LLVM, the
>>>> compilation went well, but there was a server crash. That patch
>>>> changes type of tts_nvalid from int32 to AttrNumber. I tried debugging
>>>> the crash with a debug LLVM build, but couldn't complete the work.
>>>> Attached patch attrnumber_llvm_type.patch is my incomplete attempt to
>>>> fix that crash. I think, we should make it easy to change the data
>>>> types of the members in structures shared by JIT and non-JIT code, may
>>>> be automatically create both copies of the code somehow. I will get
>>>> back to this after addressing other TODOs.
>>>>
>

still a TODO

-- 
Best Wishes,
Ashutosh Bapat
EnterpriseDB Corporation
The Postgres Database Company

Commits

Fix memory leak when inserting tuple at relation creation for CTAS
- 414a9d3cf34c 12.0 landed
Build HashState's hashkeys expression with the correct parent.
- 5f32b29c1819 12.0 landed
Move TupleTableSlots boolean member into one flag variable.
- c5257345ef61 12.0 landed
Move generic slot support functions from heaptuple.c into execTuples.c.
- 9d906f1119de 12.0 landed
Remove absolete function TupleDescGetSlot().
- 10763358c3f0 12.0 landed
Remove function list from prologue of execTuples.c.
- bbdfbb9154fc 12.0 landed
Split ExecStoreTuple into ExecStoreHeapTuple and ExecStoreBufferHeapTuple.
- 29c94e03c7d0 12.0 landed
Change TupleTableSlot->tts_nvalid to type AttrNumber.
- a598708ffa8e 12.0 landed
Deduplicate code between slot_getallattrs() and slot_getsomeattrs().
- 88ebd62fcc2e 12.0 landed
Mention ownership requirements for REFRESH MATERIALIZED VIEW in docs
- ee8012481190 12.0 cited
Spell "partitionwise" consistently.
- 31380bc7c204 12.0 cited
Fix WHERE CURRENT OF when the referenced cursor uses an index-only scan.
- 8f5ac440430a 11.0 cited