Horton

Re: jitflags in _outPlannedStmt and _readPlannedStmt treated as bool type

Ashutosh Bapat <ashutosh.bapat@enterprisedb.com>

View thread View on postgr.es
From: Ashutosh Bapat <ashutosh.bapat@enterprisedb.com>
To: Haribabu Kommi <kommi.haribabu@gmail.com>
Cc: Pg Hackers <pgsql-hackers@postgresql.org>
Date: 2018-04-26T13:33:49Z
Lists: pgsql-hackers

Attachments

On Thu, Apr 26, 2018 at 9:04 AM, Haribabu Kommi
<kommi.haribabu@gmail.com> wrote:
> The jitflags in the PlannedStmt structure of type "int", but in _out and
> _read functions it is treated as of "bool" type.
>
> WRITE_BOOL_FIELD(jitFlags);
> READ_BOOL_FIELD(jitFlags);
>
> I am thinking of it is a copy paste mistake as the other members around the
> initflags are of "bool" type or is there any specific reason to treat as
> "bool" type?

No, I don't see any. Here's patch for the same.

-- 
Best Wishes,
Ashutosh Bapat
EnterpriseDB Corporation
The Postgres Database Company

Commits

  1. Fix incorrect field type for PlannedStmt.jitFlags in outfuncs/readfuncs.