Re: Bug in ExecModifyTable function and trigger issues for foreign tables
Ashutosh Bapat <ashutosh.bapat@enterprisedb.com>
From: Ashutosh Bapat <ashutosh.bapat@enterprisedb.com>
To: Dilip Kumar <dilipbalaut@gmail.com>
Cc: Ildus Kurbangaliev <i.kurbangaliev@postgrespro.ru>, PostgreSQL Hackers <pgsql-hackers@postgresql.org>
Date: 2017-05-15T12:50:39Z
Lists: pgsql-hackers
On Mon, May 15, 2017 at 6:04 PM, Dilip Kumar <dilipbalaut@gmail.com> wrote: > On Mon, May 15, 2017 at 5:43 PM, Ashutosh Bapat > <ashutosh.bapat@enterprisedb.com> wrote: >> Yes. postgresAddForeignUpdateTargets() which is called by >> rewriteTargetListUD injects "ctid". "wholerow" is always there. Not >> for postgres_fdw but for other wrappers it might be a bad news. ctid, >> whole row obtained from the remote postgres server will fit the tuple >> descriptor of parent, but for other FDWs the column injected by >> rewriteTargetListUD() may make the child tuple look different from >> that of the parent, so we may not pass that column down to the child. > > But, can't we call rewriteTargetListUD for all the inheritors if the > inheritor is a foreign table which will intern call the > postgresAddForeignUpdateTargets? > Yes. But it's not necessary to have all children use same FDW. -- Best Wishes, Ashutosh Bapat EnterpriseDB Corporation The Postgres Database Company
Commits
-
Fix creation of resjunk tlist entries for inherited mixed UPDATE/DELETE.
- 39f180fdd1e6 9.5.11 landed
- 06ba5309682e 9.6.7 landed
- a57aa430b613 10.2 landed
- 9a785ad57317 11.0 landed