Replacing lfirst() with lfirst_node() appropriately in planner.c
Ashutosh Bapat <ashutosh.bapat@enterprisedb.com>
From: Ashutosh Bapat <ashutosh.bapat@enterprisedb.com>
To: pgsql-hackers <pgsql-hackers@postgresql.org>
Date: 2017-07-13T05:27:42Z
Lists: pgsql-hackers
Attachments
- pg_lfirst_node_planner_c.patch (application/octet-stream) patch
Hi, Happened to stumble across some instances of lfirst() which could use lfirst_node() in planner.c. Here's patch which replaces calls to lfirst() extracting node pointers by lfirst_node() in planner.c. I have covered all the occurences of lfirst() except 1. those extract generic pointers like Path, Plan etc. 2. those extract any node as Aggref, Var and then check using IsA() 3. those extracting some pointers other than nodes. "make check" runs without any failure. Are we carrying out such replacements in master or this will be considered for v11? -- Best Wishes, Ashutosh Bapat EnterpriseDB Corporation The Postgres Database Company
Commits
-
Use lfirst_node() and linitial_node() where appropriate in planner.c.
- 6e427aa4e5f3 11.0 landed