Re: postgres_fdw : altering foreign table not invalidating prepare statement execution plan.
Ashutosh Bapat <ashutosh.bapat@enterprisedb.com>
From: Ashutosh Bapat <ashutosh.bapat@enterprisedb.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Etsuro Fujita <fujita.etsuro@lab.ntt.co.jp>, Amit Langote <Langote_Amit_f8@lab.ntt.co.jp>,
Amit Langote <amitlangote09@gmail.com>, Rajkumar Raghuwanshi <rajkumar.raghuwanshi@enterprisedb.com>, pgsql-hackers <pgsql-hackers@postgresql.org>
Date: 2016-11-11T07:09:35Z
Lists: pgsql-hackers
> > That leaves the question of whether it's worth detecting table-level > option changes this way, or whether we should just handle those by forcing > a relcache inval in ATExecGenericOptions, as in Amit's original patch in > <5702298D.4090903@lab.ntt.co.jp>. I kind of like that approach; that > patch was short and sweet, and it put the cost on the unusual path (ALTER > TABLE) not the common path (every time we create a query plan). > You seemed not sure about this solution per [1]. Do you think we should add similar cache invalidation when foreign server and FDW options are modified? > That leaves not much of this patch :-( though maybe we could salvage some > of the test cases. > If that's the best way, we can add testcases to that patch. [1] https://www.postgresql.org/message-id/29681.1459779873@sss.pgh.pa.us -- Best Wishes, Ashutosh Bapat EnterpriseDB Corporation The Postgres Database Company
Commits
-
Invalidate cached plans on FDW option changes.
- e4380e4cf68a 9.4.11 landed
- c52d37c8b367 10.0 landed
- aaf12e577ee9 9.5.6 landed
- a8191800a6e6 9.3.16 landed
- 4103a2f200d6 9.6.2 landed