Horton

Thread

Commits

  1. Add missing type name "multirange" in docs chapter title

  1. doc issue missing type name "multirange" in chapter title

    Pavel Stehule <pavel.stehule@gmail.com> — 2021-05-07T05:17:23Z

    Hi

I searched operators for multirange type, and the current doc is little bit
messy, because chapter "Range Functions and Operators" contains operators
and functions for multirange type too.

I think so this chapter should be renamed to Range, Multirange Functions
and Operators"

diff --git a/doc/src/sgml/func.sgml b/doc/src/sgml/func.sgml
index 0b5571460d..f6ed1568af 100644
--- a/doc/src/sgml/func.sgml
+++ b/doc/src/sgml/func.sgml
@@ -18164,7 +18164,7 @@ SELECT NULLIF(value, '(none)') ...
   </sect1>

  <sect1 id="functions-range">
-  <title>Range Functions and Operators</title>
+  <title>Range, Multirange Functions and Operators</title>

   <para>
    See <xref linkend="rangetypes"/> for an overview of range types.

Regards

Pavel

  2. Re: doc issue missing type name "multirange" in chapter title

    Alexander Korotkov <aekorotkov@gmail.com> — 2021-06-10T20:46:46Z

    Hi!

Sorry for the late reply.

On Fri, May 7, 2021 at 8:18 AM Pavel Stehule <pavel.stehule@gmail.com> wrote:
> I searched operators for multirange type, and the current doc is little bit messy, because chapter "Range Functions and Operators" contains operators and functions for multirange type too.
>
> I think so this chapter should be renamed to Range, Multirange Functions and Operators"
>
> diff --git a/doc/src/sgml/func.sgml b/doc/src/sgml/func.sgml
> index 0b5571460d..f6ed1568af 100644
> --- a/doc/src/sgml/func.sgml
> +++ b/doc/src/sgml/func.sgml
> @@ -18164,7 +18164,7 @@ SELECT NULLIF(value, '(none)') ...
>    </sect1>
>
>   <sect1 id="functions-range">
> -  <title>Range Functions and Operators</title>
> +  <title>Range, Multirange Functions and Operators</title>
>
>    <para>
>     See <xref linkend="rangetypes"/> for an overview of range types.

Thank you for catching this.  What do you think about titling this
section "Range and Multirange Functions and Operators"?

------
Regards,
Alexander Korotkov

  3. Re: doc issue missing type name "multirange" in chapter title

    Justin Pryzby <pryzby@telsasoft.com> — 2021-06-11T00:28:21Z

    On Thu, Jun 10, 2021 at 11:46:46PM +0300, Alexander Korotkov wrote:
> On Fri, May 7, 2021 at 8:18 AM Pavel Stehule <pavel.stehule@gmail.com> wrote:
> > I searched operators for multirange type, and the current doc is little bit messy, because chapter "Range Functions and Operators" contains operators and functions for multirange type too.
> >
> > I think so this chapter should be renamed to Range, Multirange Functions and Operators"
> >
> > diff --git a/doc/src/sgml/func.sgml b/doc/src/sgml/func.sgml
> > index 0b5571460d..f6ed1568af 100644
> > --- a/doc/src/sgml/func.sgml
> > +++ b/doc/src/sgml/func.sgml
> > @@ -18164,7 +18164,7 @@ SELECT NULLIF(value, '(none)') ...
> >    </sect1>
> >
> >   <sect1 id="functions-range">
> > -  <title>Range Functions and Operators</title>
> > +  <title>Range, Multirange Functions and Operators</title>
> >
> >    <para>
> >     See <xref linkend="rangetypes"/> for an overview of range types.
> 
> Thank you for catching this.  What do you think about titling this
> section "Range and Multirange Functions and Operators"?

Yes, it should say "and".

If it's confusing to say "and" twice, then perhaps you'd say:

Functions and Operators for Range and Multirange Types

  4. Re: doc issue missing type name "multirange" in chapter title

    Tom Lane <tgl@sss.pgh.pa.us> — 2021-06-11T00:39:19Z

    Justin Pryzby <pryzby@telsasoft.com> writes:
> If it's confusing to say "and" twice, then perhaps you'd say:
> Functions and Operators for Range and Multirange Types

Uh, that's still two "and"s.  In any case, I think it's better
to keep this section heading aligned with all of its siblings.

			regards, tom lane

  5. Re: doc issue missing type name "multirange" in chapter title

    Alexander Korotkov <aekorotkov@gmail.com> — 2021-06-11T20:07:36Z

    On Fri, Jun 11, 2021 at 3:39 AM Tom Lane <tgl@sss.pgh.pa.us> wrote:
> Justin Pryzby <pryzby@telsasoft.com> writes:
> > If it's confusing to say "and" twice, then perhaps you'd say:
> > Functions and Operators for Range and Multirange Types
>
> Uh, that's still two "and"s.  In any case, I think it's better
> to keep this section heading aligned with all of its siblings.

What about "Range/Multirange Functions and Operators"?

------
Regards,
Alexander Korotkov

  6. Re: doc issue missing type name "multirange" in chapter title

    Tom Lane <tgl@sss.pgh.pa.us> — 2021-06-11T20:16:29Z

    Alexander Korotkov <aekorotkov@gmail.com> writes:
> What about "Range/Multirange Functions and Operators"?

Better than a comma, I guess.  Personally I didn't have a
problem with the form with two "ands".

			regards, tom lane

  7. Re: doc issue missing type name "multirange" in chapter title

    Alexander Korotkov <aekorotkov@gmail.com> — 2021-06-13T11:48:10Z

    On Fri, Jun 11, 2021 at 11:16 PM Tom Lane <tgl@sss.pgh.pa.us> wrote:
>
> Alexander Korotkov <aekorotkov@gmail.com> writes:
> > What about "Range/Multirange Functions and Operators"?
>
> Better than a comma, I guess.  Personally I didn't have a
> problem with the form with two "ands".

Thank you.  I propose to push the slash option because it both evades
double "and" and it's aligned with sibling section headers (we have
"Date/Time Functions and Operators").

Any objections?

------
Regards,
Alexander Korotkov

  8. Re: doc issue missing type name "multirange" in chapter title

    Alexander Korotkov <aekorotkov@gmail.com> — 2021-06-15T13:10:52Z

    On Sun, Jun 13, 2021 at 2:48 PM Alexander Korotkov <aekorotkov@gmail.com> wrote:
> On Fri, Jun 11, 2021 at 11:16 PM Tom Lane <tgl@sss.pgh.pa.us> wrote:
> >
> > Alexander Korotkov <aekorotkov@gmail.com> writes:
> > > What about "Range/Multirange Functions and Operators"?
> >
> > Better than a comma, I guess.  Personally I didn't have a
> > problem with the form with two "ands".
>
> Thank you.  I propose to push the slash option because it both evades
> double "and" and it's aligned with sibling section headers (we have
> "Date/Time Functions and Operators").
>
> Any objections?

I heard no objection.  So, pushed.

------
Regards,
Alexander Korotkov

  9. Re: doc issue missing type name "multirange" in chapter title

    Pavel Stehule <pavel.stehule@gmail.com> — 2021-06-15T13:13:21Z

    út 15. 6. 2021 v 15:11 odesílatel Alexander Korotkov <aekorotkov@gmail.com>
napsal:

> On Sun, Jun 13, 2021 at 2:48 PM Alexander Korotkov <aekorotkov@gmail.com>
> wrote:
> > On Fri, Jun 11, 2021 at 11:16 PM Tom Lane <tgl@sss.pgh.pa.us> wrote:
> > >
> > > Alexander Korotkov <aekorotkov@gmail.com> writes:
> > > > What about "Range/Multirange Functions and Operators"?
> > >
> > > Better than a comma, I guess.  Personally I didn't have a
> > > problem with the form with two "ands".
> >
> > Thank you.  I propose to push the slash option because it both evades
> > double "and" and it's aligned with sibling section headers (we have
> > "Date/Time Functions and Operators").
> >
> > Any objections?
>
> I heard no objection.  So, pushed.
>

Thank you

Pavel


> ------
> Regards,
> Alexander Korotkov
>