Re: dropdb --force
Pavel Stehule <pavel.stehule@gmail.com>
From: Pavel Stehule <pavel.stehule@gmail.com>
To: Amit Kapila <amit.kapila16@gmail.com>
Cc: Tom Lane <tgl@sss.pgh.pa.us>, vignesh C <vignesh21@gmail.com>, Dilip Kumar <dilipbalaut@gmail.com>, Ryan Lambert <ryan@rustprooflabs.com>, Thomas Munro <thomas.munro@gmail.com>, Anthony Nowocien <anowocien@gmail.com>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>, Filip Rembiałkowski <filip.rembialkowski@gmail.com>
Date: 2019-11-08T05:40:20Z
Lists: pgsql-hackers
pá 8. 11. 2019 v 6:39 odesílatel Amit Kapila <amit.kapila16@gmail.com> napsal: > On Thu, Nov 7, 2019 at 11:29 AM Pavel Stehule <pavel.stehule@gmail.com> > wrote: > > čt 7. 11. 2019 v 6:56 odesílatel Amit Kapila <amit.kapila16@gmail.com> > napsal: > >> > >> Okay, no problem. I will pick the previous version and do this. I > >> will post the patch in a day or so for your review. > > > > > > Thank you very much > > > > Did you get a chance to look at the other related patch posted by me > [1]? I have asked it before as well because I think that need to go > before this. We need to avoid errors to happen after terminating the > connections as otherwise, the termination of other databases will go > be of no use. > > I have added the comment and changed one condition in tab-completion > as otherwise, it was allowing tab completion for the following syntax: > "drop database db1 , FORCE" which doesn't make sense to me. Please, > find the result attached. Let me know what you think? > > [1] - > https://www.postgresql.org/message-id/CAA4eK1%2BqhLkCYG2oy9xug9ur_j%3DG2wQNRYAyd%2B-kZfZ1z42pLw%40mail.gmail.com I'll check it today Pavel > > > -- > With Regards, > Amit Kapila. > EnterpriseDB: http://www.enterprisedb.com >
Commits
-
Add tests for '-f' option in dropdb utility.
- 8a7e9e9dad56 13.0 landed
-
Move pump_until to TestLib.pm.
- 290acac92b1d 13.0 landed
-
Add the support for '-f' option in dropdb utility.
- 80e05a088e4e 13.0 landed
-
Introduce the 'force' option for the Drop Database command.
- 1379fd537f9f 13.0 landed
-
Improve CREATE/DROP/RENAME DATABASE so that when failing because the source
- 4abd7b49f1e9 8.4.0 cited