Re: psql: Could we get "-- " prefixing on the **** QUERY **** outputs? (ECHO_HIDDEN)

Pavel Stehule <pavel.stehule@gmail.com>

From: Pavel Stehule <pavel.stehule@gmail.com>
To: Kirk Wolak <wolakk@gmail.com>
Cc: Nathan Bossart <nathandbossart@gmail.com>, Alvaro Herrera <alvherre@alvh.no-ip.org>, "Andrey M. Borodin" <x4mmm@yandex-team.ru>, Tom Lane <tgl@sss.pgh.pa.us>, Laurenz Albe <laurenz.albe@cybertec.at>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2023-10-24T05:15:29Z
Lists: pgsql-hackers
Hi

út 24. 10. 2023 v 7:10 odesílatel Kirk Wolak <wolakk@gmail.com> napsal:

> On Wed, Jul 26, 2023 at 5:39 PM Nathan Bossart <nathandbossart@gmail.com>
> wrote:
>
>> On Wed, Jul 26, 2023 at 08:06:37AM +0200, Pavel Stehule wrote:
>> > st 26. 7. 2023 v 6:22 odesílatel Nathan Bossart <
>> nathandbossart@gmail.com>
>> > napsal:
>> >> Barring additional feedback, I think this is ready for commit.
>> >>
>> >>
>> > +1
>>
>> Great.  I spent some time on the commit message in v4.  I plan to commit
>> this shortly.
>>
>> --
>> Nathan Bossart
>> Amazon Web Services: https://aws.amazon.com
>
>
> Curious about this.  I expected to see the comments?  (is there a chance
> that the translation piece is kicking in reverting them)?
> (expecting / ********* QUERY **********/)
>
> 01:05:47 devuser@nctest= > \echo :VERSION_NAME  :VERSION_NUM
> 16.0 (Ubuntu 16.0-1.pgdg22.04+1) 160000
> 01:05:57 devuser@nctest= > \dn public
> ********* QUERY **********
> SELECT n.nspname AS "Name",
>   pg_catalog.pg_get_userbyid(n.nspowner) AS "Owner"
> FROM pg_catalog.pg_namespace n
> WHERE n.nspname OPERATOR(pg_catalog.~) '^(public)$' COLLATE
> pg_catalog.default
> ORDER BY 1;
> **************************
>
> ********* QUERY **********
> SELECT pubname
> FROM pg_catalog.pg_publication p
>      JOIN pg_catalog.pg_publication_namespace pn ON p.oid = pn.pnpubid
>      JOIN pg_catalog.pg_namespace n ON n.oid = pn.pnnspid
> WHERE n.nspname = 'public'
> ORDER BY 1
> **************************
>
>       List of schemas
>   Name  |       Owner
> --------+-------------------
>  public | pg_database_owner
> (1 row)
>
>
It is working in psql 17, not in psql 16

(2023-10-24 07:14:35) postgres=# \echo :VERSION_NAME  :VERSION_NUM
17devel 170000
(2023-10-24 07:14:37) postgres=# \l+
/******** QUERY *********/
SELECT
  d.datname as "Name",
  pg_catalog.pg_get_userbyid(d.datdba) as "Owner",
  pg_catalog.pg_encoding_to_char(d.encoding) as "Encoding",
  CASE d.datlocprovider WHEN 'c' THEN 'libc' WHEN 'i' THEN 'icu' END AS
"Locale Provider",
...




>
>
>

Commits

  1. Adjust extra lines generated by psql to be valid SQL comments.