Horton

Re: review: CHECK FUNCTION statement

Pavel Stehule <pavel.stehule@gmail.com>

View thread
From: Pavel Stehule <pavel.stehule@gmail.com>
To: Albe Laurenz <laurenz.albe@wien.gv.at>
Cc: PostgreSQL Hackers <pgsql-hackers@postgresql.org>
Date: 2011-12-14T06:33:03Z
Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. Add const qualifiers to node inspection functions

Attachments

Hello

2011/12/12 Albe Laurenz <laurenz.albe@wien.gv.at>:
> Pavel Stehule wrote:
>> there is merged patch
>
> Works fine, except that there are still missing const qualifiers
> in copyfuncs.c and equalfuncs.c that lead to compiler warnings.
>
> One thing I forgot to mention:
> I thought there was a consensus to add a WITH() or OPTIONS() clause
> to pass options to the checker function:
> http://archives.postgresql.org/message-id/12568.1322669638@sss.pgh.pa.us
>
> I think this should be there so that the API does not have to be
> changed in the future.
>

changes:

* fixed warnings
* support for options - actually only two options are supported -
quite and fatal_errors

these options are +/- useful - main reason for their existence is
testing of  support of options - processing on CHECK ... stmt side and
processing on checker function side.

options are send as 2d text array - some like
'{{quite,on},{fatal_errors,on}} - so direct call of checker function
is possible

* regress test for multi check

Regards

Pavel

> Yours,
> Laurenz Albe