Horton

Re: dropdb --force

Pavel Stehule <pavel.stehule@gmail.com>

View thread View on postgr.es
From: Pavel Stehule <pavel.stehule@gmail.com>
To: vignesh C <vignesh21@gmail.com>
Cc: Amit Kapila <amit.kapila16@gmail.com>, Dilip Kumar <dilipbalaut@gmail.com>, Ryan Lambert <ryan@rustprooflabs.com>, Tom Lane <tgl@sss.pgh.pa.us>, Thomas Munro <thomas.munro@gmail.com>, Anthony Nowocien <anowocien@gmail.com>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>, Filip Rembiałkowski <filip.rembialkowski@gmail.com>
Date: 2019-09-26T14:36:36Z
Lists: pgsql-hackers 
út 24. 9. 2019 v 17:51 odesílatel vignesh C <vignesh21@gmail.com> napsal:

> On Tue, Sep 24, 2019 at 6:22 PM Amit Kapila <amit.kapila16@gmail.com>
> wrote:
> >
> > On Sat, Sep 21, 2019 at 10:09 PM Pavel Stehule <pavel.stehule@gmail.com>
> wrote:
> > >
> > > Thank you for check. I am sending updated patch
> > >
> >
> Session termination in case of drop database is solved.
> Some typos:
> + /*
> + * Similar code to pg_terminate_backend, but we check rigts first
> + * here, and only when we have all necessary rights we start to
> + * terminate other clients. In this case we should not to raise
> + * some warnings - like "PID %d is not a PostgreSQL server process",
> + * because for this purpose - already finished session is not
> + * problem.
> + */
> "rigts" should be "rights/privilege"
> "should not to raise" could be "should not raise"
>

fixed


> Regards,
> Vignesh
> EnterpriseDB: http://www.enterprisedb.com
>

Commits

  1. Add tests for '-f' option in dropdb utility.

  2. Move pump_until to TestLib.pm.

  3. Add the support for '-f' option in dropdb utility.

  4. Introduce the 'force' option for the Drop Database command.

  5. Improve CREATE/DROP/RENAME DATABASE so that when failing because the source