Horton

Re: psql - add SHOW_ALL_RESULTS option

Pavel Stehule <pavel.stehule@gmail.com>

View thread View on postgr.es
From: Pavel Stehule <pavel.stehule@gmail.com>
To: Fabien COELHO <coelho@cri.ensmp.fr>
Cc: Peter Eisentraut <peter.eisentraut@enterprisedb.com>, "pgsql-hackers@lists.postgresql.org" <pgsql-hackers@lists.postgresql.org>
Date: 2021-07-22T06:33:09Z
Lists: pgsql-hackers 
Hi

čt 22. 7. 2021 v 7:52 odesílatel Fabien COELHO <coelho@cri.ensmp.fr> napsal:

>
> >>> The patch does not apply on Head anymore, could you rebase and post a
> >>> patch. I'm changing the status to "Waiting for Author".
> >>
> >> Ok. I noticed. The patch got significantly broken by the watch pager
> >> commit. I also have to enhance the added tests (per Peter request).
> >
> > I wrote a test to check psql query cancel support.  I checked that it
> fails
> > against the patch that was reverted.  Maybe this is useful.
>
> Thank you! The patch update is in progress…
>
> The newly added PSQL_WATCH_PAGER feature which broke the patch does not
> seem to be tested anywhere, this is tiring:-(
>

Do you have any idea how this can be tested? It requires some pager that
doesn't use blocking reading, and you need to do remote control of this
pager. So it requires a really especially written pager just for this
purpose. It is solvable, but I am not sure if it is adequate to this
patch.

Regards

Pavel



> --
> Fabien.

Commits

  1. psql: Show all query results by default

  2. psql: Refactor ProcessResult()

  3. psql: Refactor SendQuery()

  4. psql: Add test for psql behavior on server crash

  5. psql: Additional tests

  6. Improve some psql test code

  7. psql: Fix some scan-build warnings

  8. psql: Add test for handling of replication commands

  9. psql: More tests

  10. psql: Add various tests

  11. psql: Add test for query canceling

  12. Revert "psql: Show all query results by default"

  13. Extend a test case a little