Re: dropdb --force
Pavel Stehule <pavel.stehule@gmail.com>
From: Pavel Stehule <pavel.stehule@gmail.com>
To: Amit Kapila <amit.kapila16@gmail.com>
Cc: vignesh C <vignesh21@gmail.com>, Tom Lane <tgl@sss.pgh.pa.us>, Dilip Kumar <dilipbalaut@gmail.com>, Ryan Lambert <ryan@rustprooflabs.com>, Thomas Munro <thomas.munro@gmail.com>, Anthony Nowocien <anowocien@gmail.com>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>, Filip Rembiałkowski <filip.rembialkowski@gmail.com>
Date: 2019-11-18T12:59:23Z
Lists: pgsql-hackers
Attachments
- dropdb-force2.patch (text/x-patch) patch
po 18. 11. 2019 v 7:39 odesílatel Pavel Stehule <pavel.stehule@gmail.com> napsal: > > > po 18. 11. 2019 v 7:37 odesílatel Amit Kapila <amit.kapila16@gmail.com> > napsal: > >> On Mon, Nov 18, 2019 at 10:59 AM Pavel Stehule <pavel.stehule@gmail.com> >> wrote: >> > po 18. 11. 2019 v 6:24 odesílatel Amit Kapila <amit.kapila16@gmail.com> >> napsal: >> >> >> >> On Mon, Nov 18, 2019 at 10:33 AM Pavel Stehule < >> pavel.stehule@gmail.com> wrote: >> >> > >> >> > po 18. 11. 2019 v 4:43 odesílatel vignesh C <vignesh21@gmail.com> >> napsal: >> >> >> >> >> >> >> >> >> I had seen that isolation test(src/test/isolation) has a framework >> to >> >> >> support this. You can have a look to see if it can be handled using >> >> >> that. >> >> > >> >> > >> >> > I'll look there >> >> > >> >> >> >> If we want to have a test for this, then you might want to look at >> >> test src/test/recovery/t/013_crash_restart. In that test, we keep a >> >> connection open and then validate whether it is terminated. Having >> >> said that, I think it might be better to add this as a separate test >> >> patch apart from main patch because it is a bit of a timing-dependent >> >> test and might fail on some slow machines. We can always revert this >> >> if it turns out to be an unstable test. >> > >> > >> > +1 >> > >> >> So, are you planning to give it a try? I think even if we want to >> commit this separately, it is better to have a test for this before we >> commit. >> > > I'll send this test today > here is it Regards Pavel > > Pavel > > >> >> -- >> With Regards, >> Amit Kapila. >> EnterpriseDB: http://www.enterprisedb.com >> >
Commits
-
Add tests for '-f' option in dropdb utility.
- 8a7e9e9dad56 13.0 landed
-
Move pump_until to TestLib.pm.
- 290acac92b1d 13.0 landed
-
Add the support for '-f' option in dropdb utility.
- 80e05a088e4e 13.0 landed
-
Introduce the 'force' option for the Drop Database command.
- 1379fd537f9f 13.0 landed
-
Improve CREATE/DROP/RENAME DATABASE so that when failing because the source
- 4abd7b49f1e9 8.4.0 cited