Horton

Re: Schema variables - new implementation for Postgres 15

Pavel Stehule <pavel.stehule@gmail.com>

View thread
From: Pavel Stehule <pavel.stehule@gmail.com>
To: Julien Rouhaud <rjuju123@gmail.com>
Cc: Erik Rijkers <er@xs4all.nl>, Dean Rasheed <dean.a.rasheed@gmail.com>, Joel Jacobson <joel@compiler.org>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2022-08-25T17:49:38Z
Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. Allow underscores in integer and numeric constants.

  2. Remove special outfuncs/readfuncs handling of RangeVar.catalogname.

  3. Remove extra space from dumped ALTER DEFAULT PRIVILEGES.

  4. Create FKs properly when attaching table as partition

  5. psql: improve tab-complete's handling of variant SQL names.

Attachments

Hi


> - For sessionvariable.c (in 0002), I see that there are still all the
> comments
>   and code about checking type validity based on a generation number and
> other
>   heuristics.  I still fail to understand why this is needed at all as the
>   stored datum should remain compatible as long as we prevent the few
>   incompatible DDL that are also prevented when there's a relation
> dependency.
>   As an example, I try to quickly disable all that code with the following:
>
>
>
I am sending an alternative implementation based on using own int8 sequence
as protection against unwanted oid equation of different session's
variables.

This code is much shorter, and, I think better, but now, the creating
sequence in bootstrap time is dirty. Maybe instead the sequence can be used
64bite timestamp or some else - it needs a unique combination of oid, 8byte.

Regards

Pavel