Re: Compatible defaults for LEAD/LAG

Pavel Stehule <pavel.stehule@gmail.com>

From: Pavel Stehule <pavel.stehule@gmail.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Daniel Gustafsson <daniel@yesql.se>, Vik Fearing <vik@postgresfriends.org>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2020-11-04T22:00:17Z
Lists: pgsql-hackers
st 4. 11. 2020 v 22:12 odesílatel Tom Lane <tgl@sss.pgh.pa.us> napsal:

> Pavel Stehule <pavel.stehule@gmail.com> writes:
> > út 22. 9. 2020 v 2:33 odesílatel Tom Lane <tgl@sss.pgh.pa.us> napsal:
> >> Anyway, attached find
> >> 0001 - updates Vik's original patch to HEAD and tweaks the
> >> grammar in the docs a bit.
> >> 0002 - add-on patch to convert array_append, array_prepend,
> >> array_cat, array_position, array_positions, array_remove,
> >> array_replace, and width_bucket to use anycompatiblearray.
> >> I think 0001 is committable, but 0002 is just WIP since
> >> I didn't touch the docs.  I'm slightly discouraged about
> >> whether 0002 is worth proceeding with.  Any thoughts?
>
> > I think so 0002 has sense - more than doc I miss related regress tests,
> but
> > it is partially covered by anycompatible tests
>
> I didn't see any need for particularly exhaustive testing, but
> I did add one new test for an operator and one for a function.
> Pushed with that and the necessary docs work.
>

ok, Thank you

Pavel


>
>                         regards, tom lane
>

Commits

  1. Declare assorted array functions using anycompatible not anyelement.

  2. Declare lead() and lag() using anycompatible not anyelement.