Re: dropdb --force
Pavel Stehule <pavel.stehule@gmail.com>
From: Pavel Stehule <pavel.stehule@gmail.com>
To: Alvaro Herrera <alvherre@2ndquadrant.com>
Cc: Tom Lane <tgl@sss.pgh.pa.us>, Thomas Munro <thomas.munro@gmail.com>, Anthony Nowocien <anowocien@gmail.com>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>, Filip Rembiałkowski <filip.rembialkowski@gmail.com>
Date: 2019-09-03T16:49:11Z
Lists: pgsql-hackers
út 3. 9. 2019 v 18:46 odesílatel Alvaro Herrera <alvherre@2ndquadrant.com>
napsal:
> On 2019-Jul-25, Pavel Stehule wrote:
>
> > čt 25. 7. 2019 v 5:11 odesílatel Tom Lane <tgl@sss.pgh.pa.us> napsal:
> >
> > > Pavel Stehule <pavel.stehule@gmail.com> writes:
>
> > > * I'm concerned that the proposed syntax is not future-proof.
> >
> > Can be
> >
> > DROP DATABASE '(' options ...) [IF EXISTS] name
> >
> > ok?
>
> Seems weird to me. I'd rather have the options at the end with a WITH
> keyword. But that's just me, looking at gram.y for other productions
> involving ^DROP.
>
> > I don't think so server side implementation is too helpful - there is lot
> > of situations, where DDL command is much more practical.
>
> I tend to agree. Not really a fan of the double-timeout business,
> though.
>
> So when are you submitting an updated patch, addressing the other items
> that Tom mentions in his review?
>
I would to prepare patch this week.
Regards
Pavel
>
> --
> Álvaro Herrera https://www.2ndQuadrant.com/
> PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
>
Commits
-
Add tests for '-f' option in dropdb utility.
- 8a7e9e9dad56 13.0 landed
-
Move pump_until to TestLib.pm.
- 290acac92b1d 13.0 landed
-
Add the support for '-f' option in dropdb utility.
- 80e05a088e4e 13.0 landed
-
Introduce the 'force' option for the Drop Database command.
- 1379fd537f9f 13.0 landed
-
Improve CREATE/DROP/RENAME DATABASE so that when failing because the source
- 4abd7b49f1e9 8.4.0 cited