Re: proposal - function string_to_table
Pavel Stehule <pavel.stehule@gmail.com>
From: Pavel Stehule <pavel.stehule@gmail.com>
To: "movead.li@highgo.ca" <movead.li@highgo.ca>
Cc: Justin Pryzby <pryzby@telsasoft.com>,
pgsql-hackers <pgsql-hackers@postgresql.org>
Date: 2020-07-05T11:30:29Z
Lists: pgsql-hackers
Attachments
- string_to_table-20200705.patch (text/x-patch) patch
pá 5. 6. 2020 v 13:55 odesílatel Pavel Stehule <pavel.stehule@gmail.com>
napsal:
> Hi
>
> čt 4. 6. 2020 v 11:49 odesílatel movead.li@highgo.ca <movead.li@highgo.ca>
> napsal:
>
>> +{ oid => '2228', descr => 'split delimited text',
>> + proname => 'string_to_table', prorows => '1000', proretset => 't',
>> + prorettype => 'text', proargtypes => 'text text',
>> + prosrc => 'text_to_table' },
>> +{ oid => '2282', descr => 'split delimited text with null string',
>> + proname => 'string_to_table', prorows => '1000', proretset => 't',
>> + prorettype => 'text', proargtypes => 'text text text',
>> + prosrc => 'text_to_table_null' },
>>
>> I go through the patch, and everything looks good to me. But I do not know
>> why it needs a 'text_to_table_null()', it's ok to put a 'text_to_table'
>> there, I think.
>>
>
> It is a convention in Postgres - every SQL unique signature has its own
> unique internal C function.
>
> I am sending a refreshed patch.
>
rebase
Regards
Pavel
> Regards
>
> Pavel
>
>
>
>
>>
>> ------------------------------
>> Regards,
>> Highgo Software (Canada/China/Pakistan)
>> URL : www.highgo.ca
>> EMAIL: mailto:movead(dot)li(at)highgo(dot)ca
>>
>
Commits
-
Add string_to_table() function.
- 66f163068030 14.0 landed