Re: review: CHECK FUNCTION statement

Pavel Stehule <pavel.stehule@gmail.com>

From: Pavel Stehule <pavel.stehule@gmail.com>

To: Alvaro Herrera <alvherre@commandprompt.com>

Cc: PostgreSQL Hackers <pgsql-hackers@postgresql.org>

Date: 2012-03-06T14:12:57Z

Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

Add const qualifiers to node inspection functions
- d5f23af6bfbc 9.2.0 cited

Attachments

check_function-2012-03-06-2.patch.gz (application/x-gzip) patch 2012

2012/3/6 Alvaro Herrera <alvherre@commandprompt.com>:
>
> Excerpts from Pavel Stehule's message of mar mar 06 10:44:09 -0300 2012:
>>
>> 2012/3/6 Alvaro Herrera <alvherre@commandprompt.com>:
>> >
>> > Excerpts from Pavel Stehule's message of mar mar 06 03:43:06 -0300 2012:
>> >> Hello
>> >>
>> >> * I refreshed regress tests and appended tests for multi lines query
>> >> * There are enhanced checking of SELECT INTO statement
>> >> * I fixed showing details and hints
>> >
>> > Oh, I forgot to remove the do_tup_output_slot() function which I added
>> > in some previous version but is no longer necessary.  Also, there are
>> > two includes that I put separately in functioncmds.c that are only
>> > necessary for the CHECK FUNCTION stuff; those should be merged in with
>> > the other includes there.  (I was toying with the idea of moving all
>> > that code to a new file).
>> >
>>
>> I am not sure, what you did do. Can you remove this useless code, please?
>
> It's just a three line function that's not called anywhere.

ok

fixed patch

Pavel

>
> --
> Álvaro Herrera <alvherre@commandprompt.com>
> The PostgreSQL Company - Command Prompt, Inc.
> PostgreSQL Replication, Consulting, Custom Development, 24x7 support