Re: patch: ALTER TABLE IF EXISTS
Pavel Stehule <pavel.stehule@gmail.com>
From: Pavel Stehule <pavel.stehule@gmail.com>
To: Simon Riggs <simon@2ndquadrant.com>
Cc: PostgreSQL Hackers <pgsql-hackers@postgresql.org>
Date: 2012-01-02T17:01:15Z
Lists: pgsql-hackers
Attachments
- alter_table_if_exists_01.patch (text/x-patch) patch
Hello here is updated patch Regards Pavel 2012/1/2 Simon Riggs <simon@2ndquadrant.com>: > On Mon, Jan 2, 2012 at 1:11 PM, Pavel Stehule <pavel.stehule@gmail.com> wrote: > >> this is relative simple patch that add possibility to skip noexisting >> tables. It is necessary for silent cleaning when dump is loaded. > > Agreed, nice simple and uncontentious patch. > > All good apart from two minor things: > > * doc page needs to explain what IF EXISTS does, like DROP TABLE, e.g. > > IF EXISTS > Do not throw an error if the table does not exist. A notice is > issued in this case. > > * the error message is "does not exist" rather than "does not exists", > which means the code, a comment and a test need changing > > Other than that, happy to apply as soon as you make those changes. > > -- > Simon Riggs http://www.2ndQuadrant.com/ > PostgreSQL Development, 24x7 Support, Training & Services