Re: Schema variables - new implementation for Postgres 15

Pavel Stehule <pavel.stehule@gmail.com>

From: Pavel Stehule <pavel.stehule@gmail.com>

To: Julien Rouhaud <rjuju123@gmail.com>

Cc: Dean Rasheed <dean.a.rasheed@gmail.com>, Joel Jacobson <joel@compiler.org>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>

Date: 2022-03-02T05:03:06Z

Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

Allow underscores in integer and numeric constants.
- faff8f8e47f1 16.0 cited
Remove special outfuncs/readfuncs handling of RangeVar.catalogname.
- 3cece34be842 16.0 cited
Remove extra space from dumped ALTER DEFAULT PRIVILEGES.
- 2af33369e794 16.0 cited
Create FKs properly when attaching table as partition
- b0284bfb1db5 16.0 cited
psql: improve tab-complete's handling of variant SQL names.
- 02b8048ba5dc 15.0 cited

Attachments

v20220302-0002-This-patch-changes-error-message-column-doesn-t-exis.patch (text/x-patch) patch v20220302-0002
v20220302-0001-session-variables.patch (text/x-patch) patch v20220302-0001

Hi


>> +    * If this entry was created during the current transaction,
>> +    * creating_subid is the ID of the creating subxact; if created in a
>> prior
>> +    * transaction, creating_subid is zero.
>>
>> I don't see any place in the code where creating_subid can be zero? It
>> looks
>> like it's only there for future transactional implementation, but for now
>> this
>> attribute seems unnecessary?
>>
>
> The comment is not 100% valid. I removed the sentence about zero value of
> creating_subid.
>

I lost commit with this change. I am sending updated patch.

Regards

Pavel