Horton

Re: proposal: schema variables

Pavel Stehule <pavel.stehule@gmail.com>

View thread
From: Pavel Stehule <pavel.stehule@gmail.com>
To: Laurenz Albe <laurenz.albe@cybertec.at>
Cc: Erik Rijkers <er@xs4all.nl>, Michael Paquier <michael@paquier.xyz>, Amit Kapila <amit.kapila16@gmail.com>, DUVAL REMI <REMI.DUVAL@cheops.fr>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2024-10-25T20:38:01Z
Lists: pgsql-hackers, pgsql-performance

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. Move WAL sequence code into its own file

  2. Add ExplainState argument to pg_plan_query() and planner().

  3. Don't include access/htup_details.h in executor/tuptable.h

  4. Refactor to avoid code duplication in transformPLAssignStmt.

  5. Avoid including commands/dbcommands.h in so many places

  6. Restrict psql meta-commands in plain-text dumps.

  7. Split func.sgml into more manageable pieces

  8. Fix squashing algorithm for query texts

  9. EXPLAIN: Always use two fractional digits for row counts.

  10. Preliminary refactoring of plpgsql expression construction.

  11. plpgsql: pure parser and reentrant scanner

  12. Add some sanity checks in executor for query ID reporting

  13. Fix misleading error message context

  14. Add macros for looping through a List without a ListCell.

Attachments

Hi

čt 24. 10. 2024 v 10:29 odesílatel Laurenz Albe <laurenz.albe@cybertec.at>
napsal:

> ... and here is a review for patch 4
>
> I didn't change any code, just added the odd article to a comment.
>
> While running the regression tests with "make installcheck", I noticed two
> problems:
>
>   ---
> /home/laurenz/postgresql/src/test/regress/expected/session_variables.out
> 2024-10-24 11:14:06.717663613 +0300
>   +++
> /home/laurenz/postgresql/src/test/regress/results/session_variables.out
> 2024-10-24 11:15:37.999286228 +0300
>   @@ -30,6 +30,7 @@
>    GRANT ALL ON SCHEMA svartest TO regress_variable_owner;
>    CREATE VARIABLE svartest.var1 AS int;
>    CREATE ROLE regress_variable_reader;
>   +ERROR:  role "regress_variable_reader" already exists
>

> I suggest that patch 0001 should drop role "regress_variable_reader" again.
>

I did it,


>
>   @@ -107,7 +108,7 @@
>    CONTEXT:  SQL function "sqlfx" statement 1
>    SELECT plpgsqlfx(20);
>    ERROR:  permission denied for session variable var1
>   -CONTEXT:  SQL expression "$1 + var1"
>   +CONTEXT:  PL/pgSQL expression "$1 + var1"
>
> That looks like bit rot from your commit 4af123ad45.
>

fixed

merged your changes of comments





>
> Yours,
> Laurenz Albe
>