Re: patch: function xmltable

2016-12-05 0:45 GMT+01:00 Alvaro Herrera <alvherre@2ndquadrant.com>:

> Pavel Stehule wrote:
> > 2016-12-04 23:00 GMT+01:00 Pavel Stehule <pavel.stehule@gmail.com>:
>
> > > I am not sure if I understand well to your ideas - please, check
> attached
> > > patch.
>
> Thanks, that's what I meant, but I think you went a bit overboard
> creating new functions in execQual -- seems to me it would work just
> fine to have the memory switches in the same function, rather than
> having a number of separate functions just to change the context then
> call the method.  Please remove these shim functions.
>

done


>
> Also, you forgot to remove the now-unused per_rowset_memcxt struct member.
>

done


>
> Also, please rename "rc" to something more meaningful -- maybe
> "rowcount" is good enough.  And "doc" would perhaps be better as
> "document".
>

done

Regards

Pavel

>
> I'm not completely sure the structs are really sensible yet.  I may do
> some more changes tomorrow.
>
> --
> Álvaro Herrera                https://www.2ndQuadrant.com/
> PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
>