Re: pgbench - use enum for meta commands
Pavel Stehule <pavel.stehule@gmail.com>
From: Pavel Stehule <pavel.stehule@gmail.com>
To: Fabien COELHO <coelho@cri.ensmp.fr>
Cc: PostgreSQL Developers <pgsql-hackers@postgresql.org>
Date: 2017-09-23T04:16:35Z
Lists: pgsql-hackers
2017-09-23 5:45 GMT+02:00 Fabien COELHO <coelho@cri.ensmp.fr>: > > Minor code enhancement. > > While having a look at adding if/elif/else/endif to pgbench, and given the > current gset/cset added meta commands in cf queue, it occured to me that > repeated string comparisons to check for the various meta commands is > neither efficient nor readable. Use an enum instead, which are extensively > used already for other similar purposes. > +1 Pavel > -- > Fabien. > > -- > Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) > To make changes to your subscription: > http://www.postgresql.org/mailpref/pgsql-hackers > >
Commits
-
pgbench: replace run-time string comparisons with an enum identifier.
- f987f83de20a 11.0 landed