Horton

Re: CALL stmt, ERROR: unrecognized node type: 113 bug

Pavel Stehule <pavel.stehule@gmail.com>

View thread View on postgr.es
From: Pavel Stehule <pavel.stehule@gmail.com>
To: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
Cc: Tom Lane <tgl@sss.pgh.pa.us>, "David G. Johnston" <david.g.johnston@gmail.com>, Michael Paquier <michael@paquier.xyz>, Postgres hackers <pgsql-hackers@postgresql.org>, Andrew Dunstan <andrew@dunslane.net>
Date: 2018-02-12T17:24:04Z
Lists: pgsql-hackers 
2018-02-12 18:17 GMT+01:00 Peter Eisentraut <
peter.eisentraut@2ndquadrant.com>:

> On 2/9/18 09:42, Tom Lane wrote:
> > Meh.  It doesn't look significantly different to me than the restriction
> > that you can't have sub-selects in CHECK expressions, index expressions,
> > etc.  Obviously we need a clean failure like you get for those cases.
> > But otherwise it's an OK restriction that stems from exactly the same
> > cause: we do not want to invoke the full planner in this context (and
> > even if we did, we don't want to use the full executor to execute the
> > result).
>
> A close analogy is that EXECUTE parameters also don't accept subqueries.
>  It would perhaps be nice if that could be made to work, but as
> discussed it would require a bunch more work.
>

I can live with it. Should be well documented and explained.

Regards

Pavel


>
> --
> Peter Eisentraut              http://www.2ndQuadrant.com/
> PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
>

Commits

  1. Avoid premature free of pass-by-reference CALL arguments.

  2. Fix oversight in CALL argument handling, and do some minor cleanup.