Re: Remove source code display from \df+?
Pavel Stehule <pavel.stehule@gmail.com>
From: Pavel Stehule <pavel.stehule@gmail.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Magnus Hagander <magnus@hagander.net>,
Isaac Morland <isaac.morland@gmail.com>, PostgreSQL Hackers <pgsql-hackers@postgresql.org>
Date: 2023-01-12T05:22:45Z
Lists: pgsql-hackers
st 11. 1. 2023 v 22:11 odesílatel Tom Lane <tgl@sss.pgh.pa.us> napsal: > Pavel Stehule <pavel.stehule@gmail.com> writes: > > st 11. 1. 2023 v 19:31 odesílatel Magnus Hagander <magnus@hagander.net> > > napsal: > >> This is only about Internal and C, isn't it? Isn't the oid of these > >> static, and identified by INTERNALlanguageId and ClanguageId > respectively? > >> So we could just have the query show the prosrc column if the language > oid > >> is one of those two, and otherwise show "Please use \sf to view the > >> source"? > > > I think it can be acceptable - maybe we can rename the column "source > code" > > like "internal name" or some like that. > > Yeah, "source code" has always been kind of a misnomer for these > languages. > > > again I don't think printing "Please use \sf to view the source"? " > often > > can be user friendly. \? is clear and \sf is easy to use > > We could shorten it to "See \sf" or something like that. But if we change > the column header to "internal name" or the like, then the column just > obviously doesn't apply for non-internal languages, so leaving it null > should be fine. > +1 > regards, tom lane >
Commits
-
Show "internal name" not "source code" in psql's \df+ command.
- 3dfae91f7a12 16.0 landed