Re: idea: log_statement_sample_rate - bottom limit for sampling

Pavel Stehule <pavel.stehule@gmail.com>

From: Pavel Stehule <pavel.stehule@gmail.com>

To: Gilles Darold <gilles@darold.net>

Cc: PostgreSQL Hackers <pgsql-hackers@postgresql.org>

Date: 2019-06-17T20:40:56Z

Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

Revert "Add log_statement_sample_rate parameter"
- 75506195da81 13.0 landed
- d5f53a8e26ca 12.0 landed
Revert "Silence compiler warning"
- 4f9ed8f3c5ef 13.0 landed
- d8453ccfbfd6 12.0 landed

Attachments

log_statement_sample_limit.patch (text/x-patch) patch

Hi

čt 6. 6. 2019 v 10:48 odesílatel Gilles Darold <gilles@darold.net> napsal:

> Le 06/06/2019 à 10:38, Pavel Stehule a écrit :
> > Hi
> >
> > I like the idea of sampling slow statements via
> > log_statement_sample_rate. But I miss some parameter that can ensure
> > so every query executed over this limit is logged.
> >
> > Can we introduce new option
> >
> > log_statement_sampling_limit
> >
> > The query with execution time over this limit is logged every time.
> >
> > What do you think about this?
> >
> > Regards
> >
> > Pavel
>
>
> +1, log_min_duration_statement is modulated by log_statement_sample_rate
> that mean that there is no more way to log all statements over a certain
> duration limit. log_statement_sampling_limit might probably always be
> upper than log_min_duration_statement.
>

Here is a patch

Regards

Pavel


>
> --
> Gilles Darold
> http://www.darold.net/
>
>