Re: [HACKERS] [PATCH] Generic type subscripting

Pavel Stehule <pavel.stehule@gmail.com>

From: Pavel Stehule <pavel.stehule@gmail.com>

To: Dmitry Dolgov <9erthalion6@gmail.com>

Cc: Dian M Fay <dian.m.fay@gmail.com>, Tom Lane <tgl@sss.pgh.pa.us>, Andres Freund <andres@anarazel.de>, Alexander Korotkov <aekorotkov@gmail.com>, Justin Pryzby <pryzby@telsasoft.com>, David Steele <david@pgmasters.net>, Nikita Glukhov <n.gluhov@postgrespro.ru>, Alvaro Herrera <alvherre@2ndquadrant.com>, David Fetter <david@fetter.org>, Thomas Munro <thomas.munro@gmail.com>, Oleksandr Shulgin <oleksandr.shulgin@zalando.de>, Robert Haas <robertmhaas@gmail.com>, Michael Paquier <michael.paquier@gmail.com>, Oleg Bartunov <obartunov@gmail.com>, Peter Eisentraut <peter.eisentraut@2ndquadrant.com>, PostgreSQL Hackers <pgsql-hackers@postgresql.org>

Date: 2021-01-19T18:42:25Z

Lists: pgsql-hackers

Attachments

doc-whitespaces-fix.patch (text/x-patch) patch

Hi

I found minor issues.

Doc - missing tag

and three whitespaces issues

see attached patch

Following sentence is hard to read due long nested example

If the
+   path contradicts structure of modified <type>jsonb</type> for any
individual
+   value (e.g. path <literal>val['a']['b']['c']</literal> assumes keys
+   <literal>'a'</literal> and <literal>'b'</literal> have object values
+   assigned to them, but if <literal>val['a']</literal> or
+   <literal>val['b']</literal> is null, a string, or a number, then the
path
+   contradicts with the existing structure), an error is raised even if
other
+   values do conform.

It can be divided into two sentences - predicate, and example.

Regards

Pavel

Commits

Throw error when assigning jsonb scalar instead of a composite object
- aa6e46daf530 14.0 landed
Filling array gaps during jsonb subscripting
- 81fcc72e6622 14.0 landed
Implementation of subscripting for jsonb
- 676887a3b0b8 14.0 landed
Allow ALTER TYPE to update an existing type's typsubscript value.
- 8c15a297452e 14.0 landed
Allow subscripting of hstore values.
- 0ec5f7e78231 14.0 landed
Support subscripting of arbitrary types, not only arrays.
- c7aba7c14efd 14.0 landed
jit: Reference function pointer types via llvmjit_types.c.
- df99ddc70b97 14.0 landed
Teach contain_leaked_vars that assignment SubscriptingRefs are leaky.
- c0549cee07ea 13.2 landed
- 62ee70331336 14.0 landed
- 3470caa21bf8 10.16 landed
- 2f1997b1551a 12.6 landed
- 1f229f4fdcf8 11.11 landed
- 17c77c8c90f7 9.6.21 landed
jit: Correct parameter type for generated expression evaluation functions.
- 5da871bfa1ba 14.0 landed
- 1e16ad101459 11.11 landed
- 27b57f806dc2 12.6 landed
- 01c6370a32e5 13.2 landed
Renaming for new subscripting mechanism
- 558d77f20e4e 12.0 landed
Fix assertion failure for SSL connections.
- ab69ea9feeb9 12.0 cited
Teach eval_const_expressions() to handle some more cases.
- 3decd150a2d5 11.0 cited