Re: review: CHECK FUNCTION statement

Pavel Stehule <pavel.stehule@gmail.com>

From: Pavel Stehule <pavel.stehule@gmail.com>

To: Alvaro Herrera <alvherre@commandprompt.com>

Cc: Petr Jelínek <pjmodos@pjmodos.net>, Greg Smith <greg@2ndquadrant.com>, Pg Hackers <pgsql-hackers@postgresql.org>, Albe Laurenz <laurenz.albe@wien.gv.at>

Date: 2012-03-06T06:43:06Z

Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

Add const qualifiers to node inspection functions
- d5f23af6bfbc 9.2.0 cited

Attachments

check_function-2012-03-06-1.patch.gz (application/x-gzip) patch 2012

Hello

* I refreshed regress tests and appended tests for multi lines query
* There are enhanced checking of SELECT INTO statement
* I fixed showing details and hints

Regards

Pavel Stehule


2012/3/5 Alvaro Herrera <alvherre@commandprompt.com>:
> Excerpts from Pavel Stehule's message of lun mar 05 13:02:50 -0300 2012:
>> small fix of CheckFunctionById function
>>
>> Regards
>>
>> p.s. Alvaro, please, send your patch and I'll merge it
>
> Here it is, with your changes already merged.  I also added back the
> new reference doc files which were dropped after the 2012-01-01 version.
> Note I haven't touched or read the plpgsql checker code at all (only
> some automatic indentation changes IIRC).  I haven't verified the
> regression tests either.
>
> FWIW I'm not going to participate in the other thread; neither I am
> going to work any more on this patch until the other thread sees some
> reasonable conclusion.
>
> --
> Álvaro Herrera <alvherre@commandprompt.com>
> The PostgreSQL Company - Command Prompt, Inc.
> PostgreSQL Replication, Consulting, Custom Development, 24x7 support