Re: Variable substitution in psql backtick expansion

Pavel Stehule <pavel.stehule@gmail.com>

From: Pavel Stehule <pavel.stehule@gmail.com>

To: Fabien COELHO <coelho@cri.ensmp.fr>

Cc: Tom Lane <tgl@sss.pgh.pa.us>, Robert Haas <robertmhaas@gmail.com>, Corey Huinker <corey.huinker@gmail.com>, Daniel Verite <daniel@manitou-mail.org>, PostgreSQL Developers <pgsql-hackers@postgresql.org>

Date: 2017-11-10T14:49:28Z

Lists: pgsql-hackers

Attachments

psql-server-version-2.patch (text/x-patch) patch

Hi

I am sending a review of last patch psql-server-version-1.patch.gz

This patch is trivial - the most big problem is choosing correct name for
GUC. I am thinking so server_version_raw is acceptable.

I had to fix doc - see attached updated patch

All tests passed.

I'll mark this patch as ready for commiters

Regards

Pavel

Commits

Add psql variables showing server version and psql version.
- a6c678f018d3 10.0 landed
- 9ae9d8c1549c 11.0 landed
Reformat psql's --help=variables output.
- 3955c8c4eda2 11.0 landed
Remove reinvention of stringify macro.
- cd6baed78150 10.0 landed
Allow psql variable substitution to occur in backtick command strings.
- f833c847b8fa 10.0 landed