Horton
Menu

Re: proposal: possibility to read dumped table's name from file

Pavel Stehule <pavel.stehule@gmail.com>

View thread
From: Pavel Stehule <pavel.stehule@gmail.com>
To: Julien Rouhaud <rjuju123@gmail.com>
Cc: Daniel Gustafsson <daniel@yesql.se>, Andres Freund <andres@anarazel.de>, Andrew Dunstan <andrew@dunslane.net>, John Naylor <john.naylor@enterprisedb.com>, Erik Rijkers <er@xs4all.nl>, Justin Pryzby <pryzby@telsasoft.com>, Tom Lane <tgl@sss.pgh.pa.us>, Alvaro Herrera <alvherre@2ndquadrant.com>, Tomas Vondra <tomas.vondra@enterprisedb.com>, Dean Rasheed <dean.a.rasheed@gmail.com>, Stephen Frost <sfrost@snowman.net>, Surafel Temesgen <surafel3000@gmail.com>, vignesh C <vignesh21@gmail.com>, PostgreSQL Hackers <pgsql-hackers@postgresql.org>
Date: 2022-10-07T16:48:49Z
Lists: pgsql-hackers 
pá 7. 10. 2022 v 16:03 odesílatel Julien Rouhaud <rjuju123@gmail.com>
napsal:

> On Fri, Oct 07, 2022 at 07:26:08AM +0200, Pavel Stehule wrote:
> >
> > I checked this code again, and I don't think some refactoring is easy.
> > getFiltersFromFile is not duplicated. It is just probably badly named.
> >
> > These routines are used from pg_dump, pg_dumpall and pg_restore. There
> are
> > significant differences in supported objects and in types used for
> returned
> > lists (dumpOptions, SimpleStringList, and RestoreOptions). If I have one
> > routine, then I need to implement some mechanism for specification of
> > supported objects, and a special type that can be used as a proxy between
> > caller and parser to hold lists of parsed values. To be names less
> > confusing I renamed them to read_dump_filters, read_dumpall_filters and
> > read_restore_filters
>
> Ah right, I missed the different argument types.  Now that the functions
> have
> improved names it looks way clearer, and it seems just fine!
>

Thank you for check

Pavel

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. Fix array subscript warnings

  2. Read include/exclude commands for dump/restore from file

  3. Allow records to span multiple lines in pg_hba.conf and pg_ident.conf.