Re: review: CHECK FUNCTION statement

Pavel Stehule <pavel.stehule@gmail.com>

From: Pavel Stehule <pavel.stehule@gmail.com>
To: Albe Laurenz <laurenz.albe@wien.gv.at>
Cc: PostgreSQL Hackers <pgsql-hackers@postgresql.org>
Date: 2011-12-15T11:36:24Z
Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →
  1. Add const qualifiers to node inspection functions

Attachments

Hello

2011/12/15 Albe Laurenz <laurenz.albe@wien.gv.at>:
> Pavel Stehule wrote:
>> so removed "quite" option
>> and removed multiple check regression tests also - there is missing
>> explicit order of function checking, so regress tests can fail :(
>
> There seems to be a problem with the SET clause of CREATE FUNCTION:
>
> ftest=# CREATE OR REPLACE FUNCTION a(integer) RETURNS integer
>        LANGUAGE plpgsql AS 'BEGIN RETURN 2*$1; END';
> CREATE FUNCTION
> ftest=# CHECK FUNCTION a(integer);
> NOTICE:  checked function "a(integer)"
> CHECK FUNCTION
> ftest=# CREATE OR REPLACE FUNCTION a(integer) RETURNS integer
>        LANGUAGE plpgsql SET search_path=public AS 'BEGIN RETURN 2*$1; END';
> CREATE FUNCTION
> ftest=# CHECK FUNCTION a(integer);
> The connection to the server was lost. Attempting reset: Failed.
> !>
>

There was bug - missing detoast call

fixed

Regards

Pavel


> Yours,
> Laurenz Albe