Re: SUBTRANS: Minimizing calls to SubTransSetParent()

Dilip Kumar <dilipbalaut@gmail.com>

From: Dilip Kumar <dilipbalaut@gmail.com>
To: Simon Riggs <simon.riggs@enterprisedb.com>
Cc: PostgreSQL Hackers <pgsql-hackers@postgresql.org>
Date: 2022-08-11T05:31:51Z
Lists: pgsql-hackers
On Wed, Aug 10, 2022 at 6:31 PM Simon Riggs
<simon.riggs@enterprisedb.com> wrote:
>
> On Wed, 10 Aug 2022 at 08:34, Dilip Kumar <dilipbalaut@gmail.com> wrote:
> >
> > Am I still missing something?
>
> No, you have found a dependency between the patches that I was unaware
> of. So there is no bug if you apply both patches.

Right

>
> > So I still think some adjustment is required in XidInMVCCSnapdhot()
>
> That is one way to resolve the issue, but not the only one. I can also
> change AssignTransactionId() to recursively register parent xids for
> all of a subxid's parents.
>
> I will add in a test case and resolve the dependency in my next patch.

Okay, thanks, I will look into the updated patch after you submit that.

-- 
Regards,
Dilip Kumar
EnterpriseDB: http://www.enterprisedb.com



Commits

  1. Used optimized linear search in more code paths

  2. Add subxid-overflow "isolation" test