Horton

Re: pgsql: Document XLOG_INCLUDE_XID a little better

Dilip Kumar <dilipbalaut@gmail.com>

View thread View on postgr.es
From: Dilip Kumar <dilipbalaut@gmail.com>
To: Amit Kapila <amit.kapila16@gmail.com>
Cc: Alvaro Herrera <alvherre@alvh.no-ip.org>, Robert Haas <robertmhaas@gmail.com>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2021-10-20T11:47:02Z
Lists: pgsql-hackers 
On Wed, Oct 20, 2021 at 4:17 PM Amit Kapila <amit.kapila16@gmail.com> wrote:
>
> On Wed, Oct 20, 2021 at 10:25 AM Dilip Kumar <dilipbalaut@gmail.com> wrote:
> >
> > I have one comment here, basically, you have changed the function name
> > to "IsTopTransactionIdLogged", but it still behaves like
> > IsTopTransactionIdLogPending.  Now with the new name, it should return
> > (CurrentTransactionState->topXidLogged) instead of
> > (!CurrentTransactionState->topXidLogged).
> >
>
> Valid point but I think the change suggested by you won't be
> sufficient. We also need to change all the other checks in that
> function to return true which will make it a bit awkward. So instead,
> we can change the function name to IsTopTransactionIdLogPending().
> Does that make sense?

Yeah, that makes sense.

-- 
Regards,
Dilip Kumar
EnterpriseDB: http://www.enterprisedb.com

Commits

  1. Move MarkCurrentTransactionIdLoggedIfAny() out of the critical section.

  2. Replace XLOG_INCLUDE_XID flag with a more localized flag.

  3. Document XLOG_INCLUDE_XID a little better

  4. Immediately WAL-log subtransaction and top-level XID association.