Re: Fastpath while arranging the changes in LSN order in logical decoding
Dilip Kumar <dilipbalaut@gmail.com>
From: Dilip Kumar <dilipbalaut@gmail.com>
To: Andres Freund <andres@anarazel.de>
Cc: Heikki Linnakangas <hlinnaka@iki.fi>,
pgsql-hackers <pgsql-hackers@postgresql.org>
Date: 2020-03-07T04:29:38Z
Lists: pgsql-hackers
On Sat, Mar 7, 2020 at 12:30 AM Andres Freund <andres@anarazel.de> wrote: > > Hi, > > On 2020-01-08 18:06:52 +0530, Dilip Kumar wrote: > > On Wed, 8 Jan 2020 at 5:28 PM, Heikki Linnakangas <hlinnaka@iki.fi> wrote: > > > > > On 25/11/2019 05:52, Dilip Kumar wrote: > > > > In logical decoding, while sending the changes to the output plugin we > > > > need to arrange them in the LSN order. But, if there is only one > > > > transaction which is a very common case then we can avoid building the > > > > binary heap. A small patch is attached for the same. > > > > > > Does this make any measurable performance difference? Building a > > > one-element binary heap seems pretty cheap. > > > > > > I haven’t really measured the performance for this. I will try to do that > > next week. Thanks for looking into this. > > Did you do that? I tried once in my local machine but could not produce consistent results. I will try this once again in the performance machine and report back. -- Regards, Dilip Kumar EnterpriseDB: http://www.enterprisedb.com
Commits
-
logical decoding: Remove TODO about unnecessary optimization.
- 112b006fe79b 13.0 landed
-
Stamp 12.2.
- 45b88269a353 12.2 cited