Horton

Re: Conflict detection for update_deleted in logical replication

Dilip Kumar <dilipbalaut@gmail.com>

View thread View on postgr.es
From: Dilip Kumar <dilipbalaut@gmail.com>
To: Amit Kapila <amit.kapila16@gmail.com>
Cc: shveta malik <shveta.malik@gmail.com>, "Zhijie Hou (Fujitsu)" <houzj.fnst@fujitsu.com>, Masahiko Sawada <sawada.mshk@gmail.com>, "Hayato Kuroda (Fujitsu)" <kuroda.hayato@fujitsu.com>, pgsql-hackers <pgsql-hackers@postgresql.org>, vignesh C <vignesh21@gmail.com>, Nisha Moond <nisha.moond412@gmail.com>
Date: 2025-08-12T09:01:17Z
Lists: pgsql-hackers 
On Tue, Aug 12, 2025 at 2:21 PM Amit Kapila <amit.kapila16@gmail.com> wrote:
>
> On Tue, Aug 12, 2025 at 2:06 PM shveta malik <shveta.malik@gmail.com> wrote:
> >
> > 2)
> > postgres=# create subscription sub2  connection 'dbname=postgres
> > host=localhost user=shveta port=5433' publication pub2 WITH
> > (retain_dead_tuples = false, max_conflict_retention_duration=1000);
> > NOTICE:  created replication slot "sub2" on publisher
> > CREATE SUBSCRIPTION
> >
> > Shall we give notice that max_conflict_retention_duration is ignored
> > as retain_dead_tuples is false.
> >
>
> How about disallowing this combination?

+1 to disallow that.



-- 
Regards,
Dilip Kumar
Google

Commits

  1. Fix intermittent BF failures in 035_conflicts.

  2. Resume conflict-relevant data retention automatically.

  3. Fix intermittent test failure introduced in 6456c6e2c4.

  4. Fix Coverity issue reported in commit a850be2fe.

  5. Add test to prevent premature removal of conflict-relevant data.

  6. Post-commit review fixes for 228c370868.

  7. Add max_retention_duration option to subscriptions.

  8. Detect and report update_deleted conflicts.

  9. Preserve conflict-relevant data during logical replication.

  10. Integrate FullTransactionIds deeper into two-phase code

  11. Improve checks for GUC recovery_target_timeline

  12. Prevent excessive delays before launching new logrep workers.

  13. Keep WAL segments by slot's last saved restart LSN

  14. Rework some code handling pg_subscription data in psql and pg_dump

  15. Use generateClonedIndexStmt to propagate CREATE INDEX to partitions.