Re: Move pg_attribute.attcompression to earlier in struct for reduced size?

Dilip Kumar <dilipbalaut@gmail.com>

From: Dilip Kumar <dilipbalaut@gmail.com>
To: Michael Paquier <michael@paquier.xyz>
Cc: Andres Freund <andres@anarazel.de>, Tom Lane <tgl@sss.pgh.pa.us>, pgsql-hackers <pgsql-hackers@postgresql.org>, Robert Haas <robertmhaas@gmail.com>
Date: 2021-05-21T06:55:11Z
Lists: pgsql-hackers
On Fri, May 21, 2021 at 12:02 PM Michael Paquier <michael@paquier.xyz> wrote:
>
> On Tue, May 18, 2021 at 10:24:36AM +0900, Michael Paquier wrote:
> > If you switch attcompression, I'd say to go for the others while on
> > it.  It would not be the first time in history there is a catalog
> > version bump between betas.
>
> This is still an open item.  FWIW, I can get behind the reordering
> proposed by Tom for the consistency gained with pg_type, leading to
> the attached to reduce the size of FormData_pg_attribute from 116b to
> 112b.

This makes sense, thanks for working on this.

-- 
Regards,
Dilip Kumar
EnterpriseDB: http://www.enterprisedb.com



Commits

  1. Remove forced toast recompression in VACUUM FULL/CLUSTER

  2. Rethink definition of pg_attribute.attcompression.

  3. Fix memory leak when de-toasting compressed values in VACUUM FULL/CLUSTER

  4. Re-order pg_attribute columns to eliminate some padding space.

  5. Add more TAP tests for pg_dump with attribute compression