Re: SLRU optimization - configurable buffer pool and partitioning the SLRU lock

Dilip Kumar <dilipbalaut@gmail.com>

View thread View on postgr.es

From: Dilip Kumar <dilipbalaut@gmail.com>

To: "Andrey M. Borodin" <x4mmm@yandex-team.ru>

Cc: Alvaro Herrera <alvherre@alvh.no-ip.org>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>

Date: 2023-11-24T09:07:33Z

Lists: pgsql-hackers

Attachments

v8-0002-Divide-SLRU-buffers-into-banks.patch (application/octet-stream) patch v8-0002
v8-0001-Make-all-SLRU-buffer-sizes-configurable.patch (application/octet-stream) patch v8-0001
v8-0003-Remove-the-centralized-control-lock-and-LRU-count.patch (application/octet-stream) patch v8-0003
test_group_commit.patch (application/octet-stream) patch

On Fri, Nov 24, 2023 at 10:17 AM Dilip Kumar <dilipbalaut@gmail.com> wrote:
>
> On Thu, Nov 23, 2023 at 11:34 AM Dilip Kumar <dilipbalaut@gmail.com> wrote:
> >
> > Note: With this testing, we have found a bug in the bank-wise
> > approach, basically we are clearing a procglobal->clogGroupFirst, even
> > before acquiring the bank lock that means in most of the cases there
> > will be a single process in each group as a group leader
>
> I realized that the bug fix I have done is not proper, so will send
> the updated patch set with the proper fix soon.

PFA, updated patch set fixes the bug found during the testing of the
group update using the injection point.  Also attached a path to test
the injection point but for that, we need to apply the injection point
patches [1]

[1] https://www.postgresql.org/message-id/ZWACtHPetBFIvP61%40paquier.xyz

-- 
Regards,
Dilip Kumar
EnterpriseDB: http://www.enterprisedb.com

Commits

Fix zeroing of pg_serial page without SLRU bank lock
- be2f07310063 17.0 landed
Fix misspelled assertions
- 0d3a71d0c8a7 17.0 landed
GUC table: Add description to computed variables
- 30b8d6e4ce11 17.0 landed
Improve performance of subsystems on top of SLRU
- 53c2a97a9266 17.0 landed
Rename SLRU elements in view pg_stat_slru
- bcdfa5f2e2f2 17.0 landed
Use atomic access for SlruShared->latest_page_number
- d172b717c6f4 17.0 landed
Split use of SerialSLRULock, creating SerialControlLock
- 7b745d85b80d 17.0 landed
Index SLRUs by 64-bit integers rather than by 32-bit integers
- 4ed8f0913bfd 17.0 cited
Add a macro templatized hashtable.
- b30d3ea824c5 10.0 cited