Horton

Re: BUG #19026: ResourceOwnerForget can't find owner for invalid plancache

Dilip Kumar <dilipbalaut@gmail.com>

View thread
From: Dilip Kumar <dilipbalaut@gmail.com>
To: Kirill Reshke <reshkekirill@gmail.com>
Cc: exclusion@gmail.com, pgsql-bugs@lists.postgresql.org
Date: 2025-08-20T14:56:01Z
Lists: pgsql-bugs

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. Fix re-execution of a failed SQLFunctionCache entry.

On Wed, Aug 20, 2025 at 7:05 PM Kirill Reshke <reshkekirill@gmail.com> wrote:
>
> On Wed, 20 Aug 2025 at 18:25, Dilip Kumar <dilipbalaut@gmail.com> wrote:
> >
> > On Wed, Aug 20, 2025 at 5:13 PM Kirill Reshke <reshkekirill@gmail.com> wrote:
> > > How about attached?
> >
> > Thanks, right it's better to clean up in sql_exec_error_callback.  But
> > we should still release the cached plan before setting it to NULL in
> > order to leak the cache plan as I was doing in my patch.
>
> I am under the impression that we don’t. Resource owner will release
> all cached plans in the rollback tx handler.
> This can be confirmed via gdb session: print  fcache->cplan in
> sql_exec_error_callback and after this plan in ReleaseCachedPlan in
> this repro.
> These two pointers will be equal
>

That's a valid point.  Thanks.  I think we can add the same test case
to what is given in this example, maybe in plpgsql.sql or maybe some
other file which is more relevant.  So we can continue with the v1
patch only you have sent, maybe you can add a one liner comment to it.

--
Regards,
Dilip Kumar
Google