Re: [Proposal] Fully WAL logged CREATE DATABASE - No Checkpoints

Dilip Kumar <dilipbalaut@gmail.com>

From: Dilip Kumar <dilipbalaut@gmail.com>

To: Maciek Sakrejda <m.sakrejda@gmail.com>

Cc: Robert Haas <robertmhaas@gmail.com>, Bruce Momjian <bruce@momjian.us>, Alvaro Herrera <alvherre@alvh.no-ip.org>, Andrew Dunstan <andrew@dunslane.net>, Heikki Linnakangas <hlinnaka@iki.fi>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>

Date: 2022-02-15T11:48:47Z

Lists: pgsql-hackers

Attachments

v9-0001-Refactor-relmap-load-and-relmap-write-functions.patch (text/x-patch) patch v9-0001
v9-0005-New-interface-to-lock-relation-id.patch (text/x-patch) patch v9-0005
v9-0003-Refactor-index_copy_data.patch (text/x-patch) patch v9-0003
v9-0002-Extend-relmap-interfaces.patch (text/x-patch) patch v9-0002
v9-0004-Extend-bufmgr-interfaces.patch (text/x-patch) patch v9-0004
v9-0006-WAL-logged-CREATE-DATABASE.patch (text/x-patch) patch v9-0006

On Tue, Feb 15, 2022 at 2:01 AM Maciek Sakrejda <m.sakrejda@gmail.com> wrote:
>
Here is the updated version of the patch, the changes are 1) Fixed
review comments given by Robert and one open comment from Ashutosh.
2) Preserved the old create db method. 3) As agreed upthread for now
we are using the new strategy only for createdb not for movedb so I
have removed the changes in ForgetDatabaseSyncRequests() and
DropDatabaseBuffers().  3) Provided a database creation strategy
option as of now I have kept it as below.

CREATE DATABASE ... WITH (STRATEGY = WAL_LOG);      -- default if
option is omitted
CREATE DATABASE ... WITH (STRATEGY = FILE_COPY);

I have updated the document but I was not sure how much internal
information to be exposed to the user so I will work on that based on
feedback from others.

--
Regards,
Dilip Kumar
EnterpriseDB: http://www.enterprisedb.com

Commits

When using the WAL-logged CREATE DATABASE strategy, bulk extend.
- 3e63e8462f31 16.0 landed
- 576bb0fc9342 15.0 landed
Avoid using a fake relcache entry to own an SmgrRelation.
- 1b94f8f232f6 15.0 landed
- 76733b399c49 16.0 landed
Fix data-corruption hazard in WAL-logged CREATE DATABASE.
- 692df425b688 16.0 landed
- 811203d4aff5 15.0 landed
initdb: When running CREATE DATABASE, use STRATEGY = WAL_COPY.
- ad43a413c4f7 15.0 landed
Simplify a needlessly-complicated regular expression.
- c6863b858291 15.0 landed
In 020_createdb.pl, change order of command-line arguments.
- 3d067c53b26d 15.0 landed
Add new block-by-block strategy for CREATE DATABASE.
- 9c08aea6a309 15.0 landed
Fix replay of create database records on standby
- 49d9cfc68bf4 15.0 cited
Refactor code for reading and writing relation map files.
- 39f0c4bd670c 15.0 landed
Replace RelationOpenSmgr() with RelationGetSmgr().
- f10f0ae420ee 15.0 cited
Refactor the fsync queue for wider use.
- 3eb77eba5a51 12.0 cited