Re: Autovacuum launcher occurs error when cancelled by SIGINT

Dilip Kumar <dilipbalaut@gmail.com>

From: Dilip Kumar <dilipbalaut@gmail.com>
To: Kuntal Ghosh <kuntalghosh.2007@gmail.com>
Cc: Yugo Nagata <nagata@sraoss.co.jp>, PostgreSQL-development <pgsql-hackers@postgresql.org>
Date: 2017-06-21T13:37:44Z
Lists: pgsql-hackers
On Wed, Jun 21, 2017 at 6:50 PM, Kuntal Ghosh
<kuntalghosh.2007@gmail.com> wrote:
> I think we can just check dsm_find_mapping() to check whether the dsm
> handle is already attached. Something like,
>
>         }
> -       else
> +       else if(!dsm_find_mapping(AutoVacuumShmem->av_dsa_handle))
>         {
>                 AutoVacuumDSA = dsa_attach(AutoVacuumShmem->av_dsa_handle);
>                 dsa_pin_mapping(AutoVacuumDSA);
>
> Thoughts?

IMHO, It's not a good idea to use DSM call to verify the DSA handle.

-- 
Regards,
Dilip Kumar
EnterpriseDB: http://www.enterprisedb.com


Commits

  1. Fix autovacuum launcher attachment to its DSA