Re: [BUG]Update Toast data failure in logical replication

Dilip Kumar <dilipbalaut@gmail.com>

From: Dilip Kumar <dilipbalaut@gmail.com>

To: "tanghy.fnst@fujitsu.com" <tanghy.fnst@fujitsu.com>

Cc: pgsql-hackers <pgsql-hackers@postgresql.org>

Date: 2021-06-02T06:44:23Z

Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

WAL log unchanged toasted replica identity key attributes.
- 5e01001ffb38 15.0 landed
- b5e060473273 10.21 landed
- 1cd5802ac69a 11.16 landed
- ce349cf176e2 12.11 landed
- caa231be97df 13.7 landed
- 04645bbcae72 14.3 landed
Add new wal_level, logical, sufficient for logical decoding.
- e55704d8b2fe 9.4.0 cited
Add the notion of REPLICA IDENTITY for a table.
- 07cacba983ef 9.4.0 cited

Attachments

v2-0001-Extract-unchanged-replica-identity-key-if-it-is-s.patch (text/x-patch) patch v2-0001

On Tue, Jun 1, 2021 at 3:39 PM Dilip Kumar <dilipbalaut@gmail.com> wrote:
>
> On Tue, Jun 1, 2021 at 12:29 PM tanghy.fnst@fujitsu.com

> > I noticed that in case1, ExtractReplicaIdentity function returned NULL on HEAD. But after your fix, it didn’t return NULL. There is no problem with this case on HEAD, but the patch modified its return value. I’m not sure if it would bring new problems. Have you checked it?
>
> Good observation, basically, my check says that any field in the tuple
> is toasted then prepare the key tuple, actually, after that, I should
> recheck whether the key field specifically toasted or not and if it is
> not then we can continue returning NULL.  I will fix this in the next
> version.

Attached patch fixes that, I haven't yet added the test case.  Once
someone confirms on the approach then I will add a test case to the
patch.

-- 
Regards,
Dilip Kumar
EnterpriseDB: http://www.enterprisedb.com