Re: Potential problem in commit f777d773878 and 4f7f7b03758

Dilip Kumar <dilipbalaut@gmail.com>

From: Dilip Kumar <dilipbalaut@gmail.com>
To: Álvaro Herrera <alvherre@kurilemu.de>
Cc: Peter Eisentraut <peter@eisentraut.org>, Matheus Alcantara <matheusssilv97@gmail.com>, Srinath Reddy Sadipiralla <srinath2133@gmail.com>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2025-09-09T04:40:42Z
Lists: pgsql-hackers
On Mon, Sep 8, 2025 at 10:36 PM Álvaro Herrera <alvherre@kurilemu.de> wrote:
>
> On 2025-Sep-04, Dilip Kumar wrote:
>
> > What's the complain, Srinath complained that if you try to LOAD
> > '$libdir/foo' explicitly then it should load this from $libdir path
> > and it will indeed do so because it will directly call
> > expand_dynamic_library_name() and in this function if there is '/' it
> > will replace the $libdir macro with pkglib_path which is right thing
> > to do so it would behave as expected, am I missing something?
>
> Ah, I see, and I agree that this is probably the desired result.  It's
> not what you said on your first response to him though, or at least I
> didn't (and still don't) understand it that way.

I agree, when I read my response again, I realized, in that response,
I did not exactly reply to the problem he raised.

-- 
Regards,
Dilip Kumar
Google



Commits

  1. Fix: Don't strip $libdir from nested module_pathnames

  2. Don't strip $libdir from LOAD command