Re: Gather performance analysis
Dilip Kumar <dilipbalaut@gmail.com>
From: Dilip Kumar <dilipbalaut@gmail.com>
To: Zhihong Yu <zyu@yugabyte.com>
Cc: Robert Haas <robertmhaas@gmail.com>,
pgsql-hackers <pgsql-hackers@postgresql.org>
Date: 2021-09-16T07:25:06Z
Lists: pgsql-hackers
Attachments
- v2-0001-Optimize-parallel-tuple-send-shm_mq_send_bytes.patch (text/x-patch) patch v2-0001
On Sat, Aug 28, 2021 at 5:04 PM Zhihong Yu <zyu@yugabyte.com> wrote: > >> >> * mqh_partial_bytes, mqh_expected_bytes, and mqh_length_word_complete >> >> + Size mqh_send_pending; >> bool mqh_length_word_complete; >> bool mqh_counterparty_attached; >> >> I wonder if mqh_send_pending should be declared after mqh_length_word_complete - this way, the order of fields matches the order of explanation for the fields. Moved it after mqh_consume_pending and moved comment as well in the correct order. > > There was a typo in suggested code above. It should be: > > + if (force_flush || mqh->mqh_send_pending > (mq->mq_ring_size >> 2)) Done -- Regards, Dilip Kumar EnterpriseDB: http://www.enterprisedb.com
Commits
-
shm_mq: Update mq_bytes_written less often.
- 46846433a03d 15.0 landed