Re: Move pg_attribute.attcompression to earlier in struct for reduced size?
Dilip Kumar <dilipbalaut@gmail.com>
From: Dilip Kumar <dilipbalaut@gmail.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Robert Haas <robertmhaas@gmail.com>,
Michael Paquier <michael@paquier.xyz>, Andres Freund <andres@anarazel.de>,
pgsql-hackers <pgsql-hackers@postgresql.org>
Date: 2021-05-27T14:18:09Z
Lists: pgsql-hackers
On Thu, May 27, 2021 at 7:04 PM Tom Lane <tgl@sss.pgh.pa.us> wrote: > > Robert Haas <robertmhaas@gmail.com> writes: > > On Thu, May 27, 2021 at 12:11 AM Tom Lane <tgl@sss.pgh.pa.us> wrote: > >> AFAIR, there are zero promises about how effective, or when effective, > >> changes in SET STORAGE will be. And the number of complaints about > >> that has also been zero. So I'm not sure why we need to do more for > >> SET COMPRESSION. Especially since I'm unconvinced that recompressing > >> everything just to recompress everything would *ever* be worthwhile. > > > I think it is good to have *some* way of ensuring that what you want > > the system to do, it is actually doing. If we have not a single > > operation in the system anywhere that can force recompression, someone > > who actually cares will be left with no option but a dump and reload. > > That is probably both a whole lot slower than something in the server > > itself and also a pretty silly thing to have to tell people to do. > > [ shrug... ] I think the history of the SET STORAGE option teaches us > that there is no such requirement, and you're inventing a scenario that > doesn't exist in the real world. But can we compare SET STORAGE with SET compression? I mean storage just controls how the data are stored internally and there is no external dependency. But if we see the compression it will have a dependency on the external library. So if the user wants to get rid of the dependency on the external library then IMHO, there should be some way to do it by recompressing all the data. -- Regards, Dilip Kumar EnterpriseDB: http://www.enterprisedb.com
Commits
-
Remove forced toast recompression in VACUUM FULL/CLUSTER
- dbab0c07e5ba 14.0 landed
-
Rethink definition of pg_attribute.attcompression.
- e6241d8e030f 14.0 landed
-
Fix memory leak when de-toasting compressed values in VACUUM FULL/CLUSTER
- fb0f5f0172ed 14.0 landed
-
Re-order pg_attribute columns to eliminate some padding space.
- f5024d8d7b04 14.0 landed
-
Add more TAP tests for pg_dump with attribute compression
- 63db0ac3f9e6 14.0 cited